Revert stricter platform requirements #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #697. With 1.10.0, a change bumped the platform requirements, but this is hopefully not necessary.
mbrandonw
approved these changes
Jan 20, 2023
niil-qb
pushed a commit
to quickbit/swift-snapshot-testing
that referenced
this pull request
Feb 23, 2023
Fixes pointfreeco#697. With 1.10.0, a change bumped the platform requirements, but this is hopefully not necessary.
NachoSoto
added a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Apr 26, 2023
This includes [this fix](pointfreeco/swift-snapshot-testing#585) which should solve some of the flaky test failures we've been seeing lately, which made test retries also fail. We couldn't update to 1.10.0 because it dropped support for iOS 12.0, but that was fixed in pointfreeco/swift-snapshot-testing#698
NachoSoto
added a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Apr 26, 2023
This includes [this fix](pointfreeco/swift-snapshot-testing#585) which should solve some of the flaky test failures we've been seeing lately, which made test retries also fail. We couldn't update to 1.10.0 because it dropped support for iOS 12.0, but that was fixed in pointfreeco/swift-snapshot-testing#698 This also reverts #2426, since that's no longer required now that retries should work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #697.
With 1.10.0, a change bumped the platform requirements, but this is hopefully not necessary.