Skip to content

Make the image paths in Xcode XCTest output clickable #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RufusMall
Copy link
Contributor

@RufusMall RufusMall commented Nov 12, 2022

Simple change to print absolute paths if you are not using a diffing tool. This preserves the scheme of the URL , making the experience a bit nicer as you can click on the blue text to navigate to the file in finder. Or you can right click the link and open in a tool of your choice

What I tested:
I don't have KSDIFF installed, so I just eyeballed to double check the output matches. I tested with Xcode on macOS. I don't have access to be able to test other platforms :(.

Output before - when not using a diffTool:
before_notool
Output after - when not using a diffTool (notice you can click on the links to navigate to the files in finder):
after_notool

Output before - when using KSDiff:
before_ksdiff
Output after - when using KSDiff (expected to match the above)
after_ksdiff

@RufusMall RufusMall marked this pull request as ready for review November 12, 2022 02:22
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to us, thanks!

@stephencelis stephencelis merged commit 49a7e71 into pointfreeco:main Nov 14, 2022
niil-qb pushed a commit to quickbit/swift-snapshot-testing that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants