Add iPhone 13 devices #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylem
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
I can confirm all added screen size values based on useyourloaf are correct.
|
Thanks for confirming! Now, just need a review from a maintainer (: |
|
Any chance this gets in soon? |
|
Thanks for this PR @luispadron! Before maintainers approve this, is there a chance you also squeeze in the iPhone 14 line up? Thanks! |
stephencelis
approved these changes
Sep 21, 2022
|
@armanarutiunov Looks like I didn't see the comment in time sorry about that! Id make a new PR to review those separately |
niil-qb
pushed a commit
to quickbit/swift-snapshot-testing
that referenced
this pull request
Feb 23, 2023
Co-authored-by: Stephen Celis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #594
This PR adds the
iPhone13,iPhone13ProandiPhone13ProMaxdevices for snapshot testing and adds a missingiPhone12Proconfiguration.I took the numbers for device config from: https://useyourloaf.com/blog/iphone-13-screen-sizes
I believe the traits should be the same as iPhone 12