Leak when running with Host Application #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llinardos
changed the title
stephencelis
reviewed
Jan 8, 2022
| viewController.willMove(toParent: nil) | ||
| viewController.view.removeFromSuperview() | ||
| viewController.removeFromParent() | ||
| viewController.didMove(toParent: nil) |
There was a problem hiding this comment.
Can you refactor your PR so this is the only change? We'd like to keep the project file and project.yml as is.
When running with host application, rootViewController is retained by the window, and it retains the view controller we are testing (which is a child view controller). This causes a leak on the view controller we're testing. By removing the view controller from it's parent, no one retains the view controller, fixing the leak.
llinardos
force-pushed
the
fix-memory-leak-when-running-with-host-application
branch
from
5c9aeb6 to
77f2b15
Compare
niil-qb
pushed a commit
to quickbit/swift-snapshot-testing
that referenced
this pull request
Feb 23, 2023
When running with host application, rootViewController is retained by the window, and it retains the view controller we are testing (which is a child view controller). This causes a leak on the view controller we're testing. By removing the view controller from it's parent, no one retains the view controller, fixing the leak.
OksanaFedorchuk
pushed a commit
to urlaunched-com/swift-snapshot-testing
that referenced
this pull request
Mar 28, 2024
When running with host application, rootViewController is retained by the window, and it retains the view controller we are testing (which is a child view controller). This causes a leak on the view controller we're testing. By removing the view controller from it's parent, no one retains the view controller, fixing the leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #510
The cause of the leak is in the issue description 👆
The fix: By removing the view controller from its parent when the test finishes, no one retains the view controller, fixing the leak.
The same demo project that's in the issue using a branch with the fix: SnapshotTestingLeakDemo-Fixed.zip
It would be great to have this automated, but it requires a new test target that uses a host application (and also a target for the host application). I'm open to doing that, but it's adding targets to the project, not sure if you want that.