Sort URL query items #491
Merged
Sort URL query items #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Jul 22, 2021
mbrandonw
reviewed
Jul 22, 2021
|
@mihai8804858 Looks like the curl tests are failing because they weren't similarly sorted. I suggest either adding sorting to that snapshot strategy, or removing the curl tests. |
|
@mbrandonw Added back query sorting for |
mac-gallagher
pushed a commit
to mac-gallagher/swift-snapshot-testing
that referenced
this pull request
Aug 22, 2021
* Sort URL query items * Update Sources/SnapshotTesting/Snapshotting/URLRequest.swift * Update Sources/SnapshotTesting/Snapshotting/URLRequest.swift * Update Sources/SnapshotTesting/Snapshotting/URLRequest.swift * Update Sources/SnapshotTesting/Snapshotting/URLRequest.swift * Sort query items for curl Co-authored-by: Brandon Williams <[email protected]>
niil-qb
pushed a commit
to quickbit/swift-snapshot-testing
that referenced
this pull request
Feb 23, 2023
* Sort URL query items * Update Sources/SnapshotTesting/Snapshotting/URLRequest.swift * Update Sources/SnapshotTesting/Snapshotting/URLRequest.swift * Update Sources/SnapshotTesting/Snapshotting/URLRequest.swift * Update Sources/SnapshotTesting/Snapshotting/URLRequest.swift * Sort query items for curl Co-authored-by: Brandon Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an issue with snapshotting an
URLRequestthat contains multiple query items. When I'm building theURLRequestI'm using a[String: Any]dictionary for queries which results in random order of query items in the finalURLRequest.