-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows CI #156
base: main
Are you sure you want to change the base?
Fix Windows CI #156
Conversation
@compnerd Sorry to bother you again, but we're looking into fixing our Windows CI again and tried passing the I did a cursory search on GitHub code but couldn't find any invocations, just Swift source that shows the option's definition. Are we holding things wrong? |
Sadly there was a bug in the implementation and the flag on its own won’t take effect without There was another clang issue that was uncovered in the process of fixing that, but hitting it is somewhat non-deterministic. I’ve resolved the support for I’m hoping that a set of changes might be possible to repair the modules build with the older clang, but, haven’t gotten that fully worked out yet. |
@compnerd Sorry, this is a little outside my wheelhouse and I'm not sure I understand. We'd definitely take a PR from someone with more Windows experience to fix things, but as it stands I think we'll probably have to disable Windows CI on all our projects. |
No description provided.