Skip to content

get codemeta.tsv to load (displayOrder, mostly) #7844 #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

pdurbin
Copy link

@pdurbin pdurbin commented Jul 19, 2022

fieldType and displayOrder was missing here and there, resulting in errors like this (for fieldType):

{"status":"ERROR","message":"Error parsing metadata block in DATASETFIELD part, line #8: No enum constant edu.harvard.iq.dataverse.DatasetFieldType.FieldType."}

There was a different error for displayOrder. (I didn't realize it's required.) Please double-check that the order is how you like it.

I looked at this because I'm trying to stay conscious of this branch/PR as I review this one:

@pdurbin pdurbin mentioned this pull request Jul 21, 2022
3 tasks
@poikilotherm poikilotherm force-pushed the 7844-codemeta-schema branch from fcc36d0 to 1e8567d Compare July 22, 2022 08:01
@poikilotherm
Copy link
Owner

poikilotherm commented Jul 22, 2022

Thanks @pdurbin - I changed order of many fields again, changed all compound fields and updated the TSV with that. That TODO for IQSS#7877 is now solved. Thanks again!

releaseNotes Release Notes Link to release notes https://... url <a href="#VALUE" target="_blank" rel="noopener">#VALUE</a> FALSE FALSE FALSE FALSE FALSE FALSE codeMeta20 https://schema.org/releaseNotes
contIntegration Continous integration Link to continuous integration service https://... url <a href="#VALUE" target="_blank" rel="noopener">#VALUE</a> FALSE FALSE TRUE FALSE FALSE FALSE codeMeta20
issueTracker Issue Tracker Link to software bug reporting or issue tracking system https://... url <a href="#VALUE" target="_blank" rel="noopener">#VALUE</a> FALSE FALSE FALSE TRUE FALSE FALSE codeMeta20
operatingSystem Operating Systems Operating systems supported (e.g. Windows 10, OSX 11.3, Android 11). text 4 FALSE FALSE TRUE FALSE TRUE FALSE codeMeta20 https://schema.org/operatingSystem
Copy link
Owner

@poikilotherm poikilotherm Jul 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: As far as I understood the spec, the compound parent field should be type "none". Would "text" cause a problem? Would that be another valid type? Is that type important after all?

(This is an interesting question despite I switched this field back to a normal, non-compound text field)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poikilotherm whoops! You're right. Seems like it should be "none". Sorry, I was in a hurry and just trying to get the thing to load. These TSVs are a pain in the neck! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants