Skip to content

feat: cli tool register install #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Nov 4, 2024

Screenshots

  1. minikube not installed

image

  1. minikube installed

image

  1. minikube update available

image

Related issues

Fixes #149

Testing

  • unit tests has been provided
  1. go to CLITool
  2. assert minikube cli tool card is visible
  3. uninstall if already installed
  4. assert no minikube provider in the resource page
  5. install through cli tool page minikube
  6. assert minikube provider in resource page

@gastoner
Copy link

gastoner commented Nov 5, 2024

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format seems invalid

Also but maybe not related to this PR, I found this strange that the tooltip are different on the Update button on the left and the Update link on the rigth

Signed-off-by: axel7083 <[email protected]>
@axel7083
Copy link
Contributor Author

axel7083 commented Nov 5, 2024

pnpm format:fix ?

@gastoner My bad! Missed it :)

Also but maybe not related to this PR, I found this strange that the tooltip are different on the Update button on the left and the Update link on the rigth

@jeffmaury The minikube cannot change the UI, therefore I would argue the problem is on the podman-desktop side 🤔 .

@axel7083 axel7083 requested a review from jeffmaury November 5, 2024 10:13
Copy link

@gastoner gastoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, but when you try to install -> update -> uninstall -> install aggain -> you wont see update button (assuming you have instaled !latest version)

Linux WSL

Screen.Recording.2024-11-05.121016.mp4

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: axel7083 <[email protected]>
@axel7083
Copy link
Contributor Author

axel7083 commented Nov 6, 2024

@gastoner I updated the code, the problem was I wasn't checking for update after the install, only in the activate. Should be fixed now, thanks for the catch 👍

@axel7083 axel7083 requested a review from gastoner November 6, 2024 14:49
@axel7083
Copy link
Contributor Author

axel7083 commented Nov 7, 2024

@gastoner the issue you encountered is related to podman-desktop/podman-desktop#9813

@axel7083 axel7083 merged commit a8e6b18 into podman-desktop:main Nov 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube extension should register install workflow in the CLI page
3 participants