-
Notifications
You must be signed in to change notification settings - Fork 14
feat: cli tool register install #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cli tool register install #201
Conversation
Signed-off-by: axel7083 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format seems invalid
Also but maybe not related to this PR, I found this strange that the tooltip are different on the Update button on the left and the Update link on the rigth
Signed-off-by: axel7083 <[email protected]>
@gastoner My bad! Missed it :)
@jeffmaury The minikube cannot change the UI, therefore I would argue the problem is on the podman-desktop side 🤔 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, but when you try to install -> update -> uninstall -> install aggain -> you wont see update button (assuming you have instaled !latest version)
Linux WSL
Screen.Recording.2024-11-05.121016.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: axel7083 <[email protected]>
@gastoner I updated the code, the problem was I wasn't checking for update after the install, only in the activate. Should be fixed now, thanks for the catch 👍 |
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
@gastoner the issue you encountered is related to podman-desktop/podman-desktop#9813 |
Screenshots
Related issues
Fixes #149
Testing