#1548 - feature: recycle folder less duplication #1621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same as #1620 but with less duplication. Introducing RecyclableBaseDataModel feels strange to reduce duplicated code, since all ExpandoBaseDataModel inherit Recycle capabilities, but only ListItem actually is able to be recycled. I am not sure that there are others than File, Folder and List having recycle capabilities that could be inherited. I don't know, @jansenbe should I further elaborate on that? Actually I am not a fan of avoiding duplication at the cost of readability. |
mloitzl
changed the title
mloitzl
changed the title
|
@mloitzl : let's favor readability, I'll merge your other PR. |
|
@mloitzl : closing this one as the more readable version was merged. Thanks for proposing this alternative option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.