refactor(vanilla): resolve todo by removing type assertion using inferred type predicates #3134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rred type predicates
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dai-shi
reviewed
May 23, 2025
| const createStoreImpl: CreateStoreImpl = (createState) => { | ||
| type TState = ReturnType<typeof createState> | ||
| type Listener = (state: TState, prevState: TState) => void | ||
| let state: TState | ||
| const listeners: Set<Listener> = new Set() | ||
|
|
||
| const setState: StoreApi<TState>['setState'] = (partial, replace) => { | ||
| // TODO: Remove type assertion once https://github.com/microsoft/TypeScript/issues/37663 is resolved |
dai-shi
reviewed
May 23, 2025
| typeof partial === 'function' | ||
| ? (partial as (state: TState) => TState)(state) | ||
| : partial | ||
| const nextState = isFunction(partial) ? partial(state) : partial |
There was a problem hiding this comment.
This is not the goal.
It should be this:
Suggested change
| const nextState = isFunction(partial) ? partial(state) : partial | |
| const nextState = typeof partial === 'function' ? partial(state) : partial |
|
Thanks. Let's keep eyes on the upstream issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
Fixes #
Summary
Refer to the TypeScript issue 37663: T | (() => T). (you can see the issue in the previous TODO comment too)
Before TypeScript 5.5, type inference with
typeofwas not possible in this case.However, in TS 5.5+, this is now supported thanks to Inferred Type Predicates.
And I used it to resolve the todo.
Check List
pnpm run fixfor formatting and linting code and docs