test(react/vanilla-utils/freezeAtom): add tests for null and primitive handling #3076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/2XR6ZK6EE |
See documentations for usage instructions.
commit: |
dai-shi
reviewed
May 23, 2025
Co-authored-by: Daishi Kato <[email protected]>
sukvvon
commented
May 23, 2025
dai-shi
reviewed
May 23, 2025
| return ( | ||
| <> | ||
| <button onClick={() => setValue(456)}>set number</button> | ||
| <div>value is frozen: {`${Object.isFrozen(value)}`}</div> |
There was a problem hiding this comment.
I'm not sure what this is testing. Does this test pass even if we omit freezeAtom?
There was a problem hiding this comment.
Thanks for the feedback. I missed the fact that freeze doesn’t really apply to primitives. I’ll revise the test to make its purpose clearer.
sukvvon
force-pushed
the
test/react-vanilla-utils-freezeAtom-null-primitive
branch
from
3b09c55 to
209155f
Compare
dai-shi
reviewed
May 23, 2025
Comment on lines
61
to
63
| await userEvent.click(screen.getByText('set null')) | ||
|
|
||
| await screen.findByText('value is null: true') |
There was a problem hiding this comment.
Should we set something not null too?
There was a problem hiding this comment.
Should we set something not null too?
I think this should be good enough as is, but feel free to let me know if you think anything else should be added!
There was a problem hiding this comment.
L63 just passes if L61 is comment'd out, which doesn't feel like a good test. If you don't have any idea, remove L61-63.
sukvvon
commented
May 24, 2025
sukvvon
commented
May 24, 2025
Comment on lines
63
to
71
| const numberAtom = atom(123, (_get, set, _arg: number) => { | ||
| set(numberAtom, 456) | ||
| }) | ||
|
|
||
| const Component = () => { | ||
| const [value, setValue] = useAtom(freezeAtom(numberAtom)) | ||
| return ( | ||
| <> | ||
| <button onClick={() => setValue(456)}>set number</button> |
There was a problem hiding this comment.
Suggested change
| const numberAtom = atom(123, (_get, set, _arg: number) => { | |
| set(numberAtom, 456) | |
| }) | |
| const Component = () => { | |
| const [value, setValue] = useAtom(freezeAtom(numberAtom)) | |
| return ( | |
| <> | |
| <button onClick={() => setValue(456)}>set number</button> | |
| const numberAtom = atom(123, (_get, set, _ignored?) => { | |
| set(numberAtom, 456) | |
| }) | |
| const Component = () => { | |
| const [value, setValue] = useAtom(freezeAtom(numberAtom)) | |
| return ( | |
| <> | |
| <button onClick={setValue}>set number</button> |
How about aligning the format with the existing test code for consistency?
dai-shi
reviewed
May 24, 2025
Co-authored-by: Daishi Kato <[email protected]>
sukvvon
commented
May 25, 2025
sukvvon
force-pushed
the
test/react-vanilla-utils-freezeAtom-null-primitive
branch
from
16b8eef to
eedbd42
Compare
|
Let's fix the existing tests: diff --git a/tests/react/vanilla-utils/freezeAtom.test.tsx b/tests/react/vanilla-utils/freezeAtom.test.tsx
index ca135bf..11169bb 100644
--- a/tests/react/vanilla-utils/freezeAtom.test.tsx
+++ b/tests/react/vanilla-utils/freezeAtom.test.tsx
@@ -7,17 +7,16 @@ import { atom } from 'jotai/vanilla'
import { freezeAtom, freezeAtomCreator } from 'jotai/vanilla/utils'
it('freezeAtom basic test', async () => {
- const objAtom = atom({ deep: {} }, (_get, set, _ignored?) => {
- set(objAtom, { deep: {} })
- })
+ const objAtom = atom({ deep: { count: 0 } })
const Component = () => {
const [obj, setObj] = useAtom(freezeAtom(objAtom))
return (
<>
- <button onClick={setObj}>change</button>
+ <button onClick={() => setObj({ deep: { count: 1 } })}>change</button>
<div>
- isFrozen: {`${Object.isFrozen(obj) && Object.isFrozen(obj.deep)}`}
+ count: {obj.deep.count}, isFrozen:{' '}
+ {`${Object.isFrozen(obj) && Object.isFrozen(obj.deep)}`}
</div>
</>
)
@@ -29,10 +28,10 @@ it('freezeAtom basic test', async () => {
</StrictMode>,
)
- await screen.findByText('isFrozen: true')
+ await screen.findByText('count: 0, isFrozen: true')
await userEvent.click(screen.getByText('change'))
- await screen.findByText('isFrozen: true')
+ await screen.findByText('count: 1, isFrozen: true')
})
describe('freezeAtomCreator', () => { |
sukvvon
force-pushed
the
test/react-vanilla-utils-freezeAtom-null-primitive
branch
from
afde2e2 to
dba579e
Compare
I reflected it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
Fixes #
Summary
before
after
Check List
pnpm run fixfor formatting and linting code and docs