Skip to content

fix(atomWithRefresh): non-writable refreshables throw an error if implicitly passed an argument #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 22, 2025

Conversation

a10nik
Copy link
Contributor

@a10nik a10nik commented Feb 20, 2025

Related Bug Reports or Discussions

#2995

Fixes #

Summary

Proposed fix for the issue where passing something into the refresh function causes it to do nothing.

Check List

  • pnpm run fix for formatting and linting code and docs

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2025 4:14am

Copy link

codesandbox-ci bot commented Feb 20, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@a10nik a10nik changed the title fix(atomWithRefresh): non-writable refreshables no longer break if implicitly passed an argument fix(atomWithRefresh): non-writable refreshables throw an error if implicitly passed an argument Feb 22, 2025
Copy link

pkg-pr-new bot commented Feb 22, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2996

commit: 09ff28b

Copy link

github-actions bot commented Feb 22, 2025

LiveCodes Preview in LiveCodes

Latest commit: 09ff28b
Last updated: Feb 22, 2025 4:13am (UTC)

Playground Link
React demo https://livecodes.io?x=id/7V74UHHB8

See documentations for usage instructions.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@dai-shi dai-shi merged commit bc39611 into pmndrs:main Feb 22, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants