add failing tests for unstable_resolve #2574
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/6B4T8CKYA |
See documentations for usage instructions.
|
wait, i can just merge it, can i? |
tests/vanilla/store.test.tsx
Outdated
| import test from 'node:test' | ||
| import exp from 'node:constants' |
There was a problem hiding this comment.
oh, I think my IDE accidentally added them. I will remove.
|
https://github.com/pmndrs/jotai/actions/runs/9231515051/job/25401510369?pr=2574 are type errors expected? |
dmaskasky
force-pushed
the
expose-store-get-atom
branch
from
4abb605 to
b6c96a9
Compare
yeah, go ahead. |
Yes |
|
Now, I'm not quite sure what would be the correct typing. We can revisit in the future. Merging for now. |
* add failing tests for unstable_resolve * Apply suggestions from code review * Apply suggestions from code review * Update tests/vanilla/store.test.tsx * hack types --------- Co-authored-by: Daishi Kato <[email protected]> Co-authored-by: daishi <[email protected]>
* add failing tests for unstable_resolve * Apply suggestions from code review * Apply suggestions from code review * Update tests/vanilla/store.test.tsx * hack types --------- Co-authored-by: Daishi Kato <[email protected]> Co-authored-by: daishi <[email protected]>
No description provided.