Skip to content

fix(utils/atomWithHash): do not cause error when location is not available #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Aug 29, 2022

Seems like a regression in #1363

Fixes #1377


I wonder if there's a better way in general not only for SSR/SSG.
fwiw, #1373 is not SSR, but RN.
but, the goal of #1363 is not to hide exceptions, so we need to get feedback for "expected" usage.

@vercel
Copy link

vercel bot commented Aug 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
jotai ✅ Ready (Inspect) Visit Preview Aug 29, 2022 at 7:58AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9a51630:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

Size Change: +86 B (0%)

Total Size: 147 kB

Filename Size Change
dist/esm/utils.js 5.18 kB +14 B (0%)
dist/system/utils.development.js 5.53 kB +15 B (0%)
dist/system/utils.production.js 3.48 kB +13 B (0%)
dist/umd/utils.development.js 9.91 kB +15 B (0%)
dist/umd/utils.production.js 6.39 kB +14 B (0%)
dist/utils.js 9.71 kB +15 B (0%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 952 B
dist/babel/plugin-react-refresh.js 1.17 kB
dist/babel/preset.js 1.42 kB
dist/devtools.js 4.01 kB
dist/esm/babel/plugin-debug-label.js 807 B
dist/esm/babel/plugin-react-refresh.js 1.01 kB
dist/esm/babel/preset.js 1.26 kB
dist/esm/devtools.js 3.14 kB
dist/esm/immer.js 643 B
dist/esm/index.js 5.21 kB
dist/esm/optics.js 668 B
dist/esm/query.js 1.17 kB
dist/esm/redux.js 254 B
dist/esm/urql.js 1.33 kB
dist/esm/valtio.js 540 B
dist/esm/xstate.js 872 B
dist/esm/zustand.js 289 B
dist/immer.js 726 B
dist/index.js 6.23 kB
dist/optics.js 938 B
dist/query.js 1.27 kB
dist/redux.js 314 B
dist/system/babel/plugin-debug-label.development.js 917 B
dist/system/babel/plugin-debug-label.production.js 682 B
dist/system/babel/plugin-react-refresh.development.js 1.11 kB
dist/system/babel/plugin-react-refresh.production.js 869 B
dist/system/babel/preset.development.js 1.37 kB
dist/system/babel/preset.production.js 1.06 kB
dist/system/devtools.development.js 3.32 kB
dist/system/devtools.production.js 2.38 kB
dist/system/immer.development.js 772 B
dist/system/immer.production.js 469 B
dist/system/index.development.js 5.44 kB
dist/system/index.production.js 3.01 kB
dist/system/optics.development.js 770 B
dist/system/optics.production.js 455 B
dist/system/query.development.js 1.32 kB
dist/system/query.production.js 1.08 kB
dist/system/redux.development.js 344 B
dist/system/redux.production.js 217 B
dist/system/urql.development.js 1.49 kB
dist/system/urql.production.js 1.01 kB
dist/system/valtio.development.js 652 B
dist/system/valtio.production.js 400 B
dist/system/xstate.development.js 981 B
dist/system/xstate.production.js 626 B
dist/system/zustand.development.js 377 B
dist/system/zustand.production.js 235 B
dist/umd/babel/plugin-debug-label.development.js 1.11 kB
dist/umd/babel/plugin-debug-label.production.js 844 B
dist/umd/babel/plugin-react-refresh.development.js 1.32 kB
dist/umd/babel/plugin-react-refresh.production.js 1 kB
dist/umd/babel/preset.development.js 1.56 kB
dist/umd/babel/preset.production.js 1.19 kB
dist/umd/devtools.development.js 4.13 kB
dist/umd/devtools.production.js 2.86 kB
dist/umd/immer.development.js 871 B
dist/umd/immer.production.js 570 B
dist/umd/index.development.js 6.32 kB
dist/umd/index.production.js 3.46 kB
dist/umd/optics.development.js 1.08 kB
dist/umd/optics.production.js 671 B
dist/umd/query.development.js 1.42 kB
dist/umd/query.production.js 1.1 kB
dist/umd/redux.development.js 454 B
dist/umd/redux.production.js 322 B
dist/umd/urql.development.js 1.77 kB
dist/umd/urql.production.js 1.22 kB
dist/umd/valtio.development.js 722 B
dist/umd/valtio.production.js 500 B
dist/umd/xstate.development.js 1.45 kB
dist/umd/xstate.production.js 912 B
dist/umd/zustand.development.js 479 B
dist/umd/zustand.production.js 334 B
dist/urql.js 1.62 kB
dist/valtio.js 586 B
dist/xstate.js 1.31 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi dai-shi added this to the v1.8.2 milestone Aug 29, 2022
@dai-shi dai-shi merged commit 5d14562 into main Aug 30, 2022
@dai-shi dai-shi deleted the fix/issue-1377 branch August 30, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atomWithStorage is broken with Gatsby-SSG in 1.8.1
1 participant