Feat/use sprite loader spritesheet grid detection #1971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idth, frame-height) for single (no data) spritesheets for useSpriteLoader
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
useSpriteLoader now can support multi-rows/columns single spritesheets that don't come with .json descriptor files. It also detects and returns rows and columns as meta information, this is useful in various scenarios
What
I added a function that can detect rows, columns, frame-width and frame-height from the given
texture.imageand the number of frames of the spritesheet. The solution also heuristically tries to detect empty frames on the spritesheet and exclude them from the total rows and columns count.Checklist
No changes needed on the API, this function works internally.