Validate transaction slots #6304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each inventory can provide any validator for their transaction
ShockedPlot7560
added
Category: API
dktapps
reviewed
Mar 24, 2024
src/inventory/transaction/validator/ArmorInventoryValidator.php
Outdated
Show resolved
Hide resolved
src/inventory/transaction/validator/InventoryTransactionValidator.php
Outdated
Show resolved
Hide resolved
dktapps
requested changes
Mar 29, 2024
There was a problem hiding this comment.
Concept looks fine.
However, as previously discussed on Discord, I think that all validators should accept the item in order to allow the transaction to proceed, as opposed to the current behaviour of only one. The current behaviour does not make sense to me - I think it's more likely that people will want to add extra restrictions instead of overriding existing ones
|
Alright, I think we are done with this. |
dktapps
reviewed
Apr 1, 2024
dktapps
reviewed
Apr 1, 2024
dktapps
reviewed
Apr 1, 2024
dktapps
reviewed
Apr 1, 2024
Co-authored-by: Dylan T. <[email protected]>
dktapps
reviewed
Apr 3, 2024
ipad54
reviewed
Apr 4, 2024
Co-authored-by: ipad54 <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dktapps
previously approved these changes
Aug 22, 2024
ipad54
reviewed
Aug 23, 2024
Co-authored-by: ipad54 <[email protected]>
ShockedPlot7560
dismissed stale reviews from dktapps and github-actions[bot]
via
e76f03c
dktapps
previously approved these changes
Aug 26, 2024
ipad54
reviewed
Aug 26, 2024
jasonw4331
approved these changes
Aug 27, 2024
dries-c
dismissed stale reviews from dktapps and github-actions[bot]
via
e8adc49
dries-c
approved these changes
Aug 29, 2024
IvanCraft623
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
At present, we can place an item in any slot in an inventory (except in exceptional cases).
It is now necessary to provide a system for verifying transactions in order to guarantee a stable internal state for each inventory.
To maintain compatibility and avoid changing the Inventory interface. A new interface has been created, introducing a new notion of : "slot safe".
I named an inventory slot safe when we are guaranteed that the internal state is consistent with what it should do. So it's up to the core (for inventory implemented by pmmp) and plugin developers to make sure they implement the right validation logic.
Relevant issues
Changes
API changes
SlotSafeInventorySlotValidatorBehavioural changes
ArmorInventorychecked now correctly their slots.Backwards compatibility
Enforced by the
SlotSafeInventoryFollow-up
As proof of concept, I only implement the
ArmorInventorylogics. There is many inventory which need to check their slot.