Skip to content

Implement Shield (wip) #6296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

Implement Shield (wip) #6296

wants to merge 21 commits into from

Conversation

pandaaaBE
Copy link
Contributor

@pandaaaBE pandaaaBE commented Mar 22, 2024 •
edited
Loading

Introduction

This PR adds working shield.

this will have a lot of commits because i am working on 2 different desktops and this is the best way for me to save the files sry bros

Changes

API changes

VanillaItems::SHIELD()
Item::canDisableShield() in Item.php & Axe.php

Tests

I tested this PR by doing the following (tick all that apply):

  • Playtesting using a Minecraft client (provide screenshots or a video)

@ShockedPlot7560 ShockedPlot7560 added Category: Gameplay Related to Minecraft gameplay experience Status: Incomplete Work in progress Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Mar 23, 2024
@pandaaaBE pandaaaBE changed the title Implement Shield Implement Shield (wip) Mar 24, 2024
JavierLeon9966
JavierLeon9966 suggested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@JavierLeon9966 JavierLeon9966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of naming the methods and properties breakShield it should be like "shield disabled". canDisableShield, isShieldDisabled, getShieldDisableCooldown, etc.

@pandaaaBE pandaaaBE closed this Jul 5, 2024
@pandaaaBE
Copy link
Contributor Author

Closed because the current code is probably not good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JavierLeon9966 JavierLeon9966 JavierLeon9966 requested changes

Assignees
No one assigned
Labels
Category: Gameplay Related to Minecraft gameplay experience Status: Incomplete Work in progress Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pandaaaBE @JavierLeon9966 @ShockedPlot7560