feat: Support Airbyte on Azure #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciaszczykm
changed the title
maciaszczykm
force-pushed
the
marcin/prod-3112-airbyte-azure-setup
branch
from
7a5d3d8 to
095cd50
Compare
maciaszczykm
force-pushed
the
marcin/prod-3112-airbyte-azure-setup
branch
from
095cd50 to
05de99f
Compare
| @@ -0,0 +1,28 @@ | |||
| output "connection_string" { | |||
| value = data.azurerm_storage_account.airbyte.primary_connection_string | |||
There was a problem hiding this comment.
i feel like there's got to be a more secure way to configure this if possible?
There was a problem hiding this comment.
I should be able to put it in a secret, but we will still need to provide it. Connection string is the only method presented in Airbyte chart values.
michaeljguarino
approved these changes
Apr 1, 2025
|
To get the test to work, you need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://artifacthub.io/packages/helm/airbyte/airbyte.