Skip to content

remove the note that Volto can't be contributed using Weblate #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 1, 2025

Conversation

erral
Copy link
Member

@erral erral commented Mar 29, 2025

First-time contributors

You must read and follow our First-time contributors.


Submit a pull request

Thank you for your contribution to the Plone Documentation.

Before submitting this pull request, please make sure you follow our guides:

Issue number

  • Fixes #

Description

Write a description of the fixes or improvements.

Add screenshots or links to a preview of the changes

@stevepiercy @sneridagh see:

plone/volto#6911
plone/volto#6910

We only need to manually add the changelog (I volunteer to do so) and skip somehow the contributor check for weblate.


📚 Documentation preview 📚: https://plone6--1928.org.readthedocs.build/

stevepiercy
stevepiercy previously approved these changes Mar 29, 2025
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeeeeet!

@stevepiercy stevepiercy moved this from New to Approved in Plone Documentation Mar 29, 2025
@stevepiercy
Copy link
Contributor

@ksuess I think you'll be interested in this.

@github-project-automation github-project-automation bot moved this to Needs discussion in Volto Team Meeting Mar 29, 2025
@stevepiercy stevepiercy moved this from Needs discussion to Work approved in Volto Team Meeting Mar 29, 2025
@stevepiercy
Copy link
Contributor

I've added this as a topic to the next Volto Team meeting agenda. As maintainers before merging the PRs from Weblate, we need to make sure that any contributor has signed the PCA. I think we discussed this once before, but I can't remember whether we reached a conclusion.

@stevepiercy
Copy link
Contributor

I can't find any way to determine who made a translation contribution through Weblate for a given PR.

We can add a contributor license agreement as a configuration item in Weblate.

We can add the {{ author }} slug to various message templates.

With the combination of the two, that might be enough. @polyester @ableeb do you have opinions about this meta contributor issue?

@fredvd @mr-roboto complains that @weblate has not signed the PCA. We should change this message specifically to address the maintainers not to merge it until the author of the PR has signed the PCA. @erral what is the frequency that Weblate submits PRs, and can we make it such that they are grouped by an individual contributor?

@stevepiercy
Copy link
Contributor

@erral I would like to merge this PR because it is correct, and not hold it up for bureaucratic reasons. But at the same time, I don't want to create a huge administrative mess to clean up afterward regarding the PCA, such as having to rip out translations by non-signatories of the PCA. What are your thoughts?

@erral
Copy link
Member Author

erral commented Mar 29, 2025

I think I heard from @polyester, but I may be wrong, that contributing translations can be understood as non-meaningful-contribution regarding the PCA.

Moreover, plone's own translations live on collective, and it is specifically stated that PCA is not required to contribute to them.

The point here is that is weblate user who creates the PR and whose email is checked with the contributors list.

@stevepiercy
Copy link
Contributor

@erral good points. Once we get confirmation, we should make it explicit in the docs that a signed PCA for translations—whether through Weblate or GitHub—is not required. I don't want to point contributors to do something they don't need to do and make needless work for everyone.

In fact, we lost a Swedish translation for Volto because we thought a signed PCA was required.

And we'll need to update mr-roboto messages to account for this exception.

@erral
Copy link
Member Author

erral commented Mar 29, 2025

@fredvd @mr-roboto complains that @weblate has not signed the PCA. We should change this message specifically to address the maintainers not to merge it until the author of the PR has signed the PCA. @erral what is the frequency that Weblate submits PRs, and can we make it such that they are grouped by an individual contributor?

weblate does a PR when it has unmerged contributions.

If we merge a PR, it waits until a translation is contributed, and it creates a PR then

Internally it clones the repo and makes commits in there before pushing to a specific branch here and opening the PR.

@polyester
Copy link
Member

polyester commented Mar 29, 2025

it's a bit murky. Most lawyers (and courts) have held the view that translation strings do not constitute an original 'work'. After all, there's only so much ways to say "open file"...

The longer and more unique a piece of text becomes, the more it would resemble a 'work'. But overall, I would say we would be safe in not requiring PCA.

It would be nice to keep a list of contributors as acknowledgment, but it can get messy when someone decides to use machine-generated translations to 'harvest' those kudo points - we should only acknowledge human effort.
(machine translations are in no way covered under any kind of copyright, the person using the software cannot claim ownership)

@stevepiercy
Copy link
Contributor

Thanks @polyester.

I've run out of steam for today, but I'll amend this PR to handle this exception to the PCA, unless someone else wants to tackle it before I wake up tomorrow.

@erral
Copy link
Member Author

erral commented Mar 29, 2025

I have done so. I will let you review the wording. Thanks @stevepiercy & @polyester for your insights!

@erral erral requested a review from polyester March 29, 2025 12:15
@stevepiercy
Copy link
Contributor

I committed a revision. @polyester would you please take another pass at this version?

I considered adding these two sentences, but realized this is how-to documentation, not a place for explanation. I also didn't want to overreach into yet unpublished AI policy. I would suggest adding it to plone.org under the PCA or AI policy, whenever the Board publishes it. I'll create a separate issue in that repo from this comment.

Moreover, if you use artificial intelligence (AI) software to generate translations, you cannot claim ownership of these works, and therefore cannot assign ownership of them to the Plone Foundation according to the PCA.
In fact, using AI may be grounds for allegations of plagiarism or copyright infringement, as it is impossible to know the sources from which the AI draws its output.

@stevepiercy
Copy link
Contributor

I created a new issue under the plone.org repo, and assigned it to several people and the @plone-foundation Board, so that we can proceed with merging this PR.

plone/plone.org#197

I also updated a Google Doc that lays out the plan for me and @fredvd to handle removal of the Plone GitHub Contributors Team, by excluding @mr-roboto from checking the @weblate GitHub user for whether it signed the PCA.

Two final things, after a merge:

  • Announce to the Community Forum that we can now accept translations through Weblate for all Plone projects, and that we don't require signing the PCA to do so.
  • Reopen the closed PR in Volto Feature swedish translation volto#5958, inform the author that we made a mistake in requiring the PCA per this policy clarification, beg his forgiveness for our error, and request permission to merge the PR as originally submitted. I'm happy to do that, unless it would be more advisable for @sneridagh or a @plone-foundation Board member to do so.

@sneridagh
Copy link
Member

Regarding Swedish translation, please wait, since Mack Palomäki (I don't know his GH handle) was working on it, (and in a way to improve the whole workflow using AI) during the Bucharest Sprint. More on the subject in the sprint report.

mauritsvanrees added a commit to plone/mr.roboto that referenced this pull request Mar 31, 2025
@mauritsvanrees
Copy link
Member

by excluding @mr-roboto from checking the @weblate GitHub user for whether it signed the PCA.

I have made a PR for this:
plone/mr.roboto#167

@stevepiercy
Copy link
Contributor

Regarding Swedish translation, please wait, since Mack Palomäki (I don't know his GH handle) was working on it, (and in a way to improve the whole workflow using AI) during the Bucharest Sprint. More on the subject in the sprint report.

@sneridagh I read the Bucharest sprint doc, and @erral might know. If anyone can contact Mack Palomäki, please connect us, and I can help him get started with docs. I'll wait on the Community Forum announcement, because if there is a better workflow to be documented, it'd be better to wait.

@mauritsvanrees thanks for the PR! The noise in Volto from @mr-roboto has greatly diminished.

@polyester could I get a final review from you on the latest change in 960c534?

@erral
Copy link
Member Author

erral commented Apr 1, 2025

Regarding Swedish translation, please wait, since Mack Palomäki (I don't know his GH handle) was working on it, (and in a way to improve the whole workflow using AI) during the Bucharest Sprint. More on the subject in the sprint report.

@sneridagh I read the Bucharest sprint doc, and @erral might know. If anyone can contact Mack Palomäki, please connect us, and I can help him get started with docs. I'll wait on the Community Forum announcement, because if there is a better workflow to be documented, it'd be better to wait.

FYI I talked to Mack last week, Érico introduced me to him. I have scheduled a meeting with Mack this week to talk about his project.

@mauritsvanrees thanks for the PR! The noise in Volto from @mr-roboto has greatly diminished.

@polyester could I get a final review from you on the latest change in 960c534?

@stevepiercy stevepiercy merged commit 78ab875 into 6.0 Apr 1, 2025
3 checks passed
@stevepiercy stevepiercy deleted the erral-volto-translations-in-weblate branch April 1, 2025 09:57
@github-project-automation github-project-automation bot moved this from Work approved to Done in Volto Team Meeting Apr 1, 2025
@github-project-automation github-project-automation bot moved this from Approved to Done in Plone Documentation Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants