-
-
Notifications
You must be signed in to change notification settings - Fork 176
remove the note that Volto can't be contributed using Weblate #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweeeeeeet!
@ksuess I think you'll be interested in this. |
I've added this as a topic to the next Volto Team meeting agenda. As maintainers before merging the PRs from Weblate, we need to make sure that any contributor has signed the PCA. I think we discussed this once before, but I can't remember whether we reached a conclusion. |
I can't find any way to determine who made a translation contribution through Weblate for a given PR. We can add a contributor license agreement as a configuration item in Weblate. We can add the With the combination of the two, that might be enough. @polyester @ableeb do you have opinions about this meta contributor issue? @fredvd |
@erral I would like to merge this PR because it is correct, and not hold it up for bureaucratic reasons. But at the same time, I don't want to create a huge administrative mess to clean up afterward regarding the PCA, such as having to rip out translations by non-signatories of the PCA. What are your thoughts? |
I think I heard from @polyester, but I may be wrong, that contributing translations can be understood as non-meaningful-contribution regarding the PCA. Moreover, plone's own translations live on collective, and it is specifically stated that PCA is not required to contribute to them. The point here is that is weblate user who creates the PR and whose email is checked with the contributors list. |
@erral good points. Once we get confirmation, we should make it explicit in the docs that a signed PCA for translations—whether through Weblate or GitHub—is not required. I don't want to point contributors to do something they don't need to do and make needless work for everyone. In fact, we lost a Swedish translation for Volto because we thought a signed PCA was required. And we'll need to update mr-roboto messages to account for this exception. |
weblate does a PR when it has unmerged contributions. If we merge a PR, it waits until a translation is contributed, and it creates a PR then Internally it clones the repo and makes commits in there before pushing to a specific branch here and opening the PR. |
it's a bit murky. Most lawyers (and courts) have held the view that translation strings do not constitute an original 'work'. After all, there's only so much ways to say "open file"... The longer and more unique a piece of text becomes, the more it would resemble a 'work'. But overall, I would say we would be safe in not requiring PCA. It would be nice to keep a list of contributors as acknowledgment, but it can get messy when someone decides to use machine-generated translations to 'harvest' those kudo points - we should only acknowledge human effort. |
Thanks @polyester. I've run out of steam for today, but I'll amend this PR to handle this exception to the PCA, unless someone else wants to tackle it before I wake up tomorrow. |
I have done so. I will let you review the wording. Thanks @stevepiercy & @polyester for your insights! |
I committed a revision. @polyester would you please take another pass at this version? I considered adding these two sentences, but realized this is how-to documentation, not a place for explanation. I also didn't want to overreach into yet unpublished AI policy. I would suggest adding it to plone.org under the PCA or AI policy, whenever the Board publishes it. I'll create a separate issue in that repo from this comment.
|
I created a new issue under the I also updated a Google Doc that lays out the plan for me and @fredvd to handle removal of the Plone GitHub Contributors Team, by excluding Two final things, after a merge:
|
Regarding Swedish translation, please wait, since Mack Palomäki (I don't know his GH handle) was working on it, (and in a way to improve the whole workflow using AI) during the Bucharest Sprint. More on the subject in the sprint report. |
I have made a PR for this: |
@sneridagh I read the Bucharest sprint doc, and @erral might know. If anyone can contact Mack Palomäki, please connect us, and I can help him get started with docs. I'll wait on the Community Forum announcement, because if there is a better workflow to be documented, it'd be better to wait. @mauritsvanrees thanks for the PR! The noise in Volto from @polyester could I get a final review from you on the latest change in 960c534? |
FYI I talked to Mack last week, Érico introduced me to him. I have scheduled a meeting with Mack this week to talk about his project.
|
First-time contributors
You must read and follow our First-time contributors.
Submit a pull request
Thank you for your contribution to the Plone Documentation.
Before submitting this pull request, please make sure you follow our guides:
Issue number
Description
Write a description of the fixes or improvements.
Add screenshots or links to a preview of the changes
@stevepiercy @sneridagh see:
plone/volto#6911
plone/volto#6910
We only need to manually add the changelog (I volunteer to do so) and skip somehow the contributor check for weblate.
📚 Documentation preview 📚: https://plone6--1928.org.readthedocs.build/