Skip to content

ScriptAttribute fix #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2024
Merged

ScriptAttribute fix #6750

merged 4 commits into from
Jun 25, 2024

Conversation

marklundin
Copy link
Member

Add's a guard around assigning attributes where the data is invalid. Also exposes the attributeToValue method as a static member of the ScriptAttribute class.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@marklundin marklundin requested a review from mvaligursky June 25, 2024 10:16
@marklundin marklundin merged commit 03920de into main Jun 25, 2024
8 checks passed
@marklundin marklundin deleted the attrib-value-export branch August 29, 2024 11:27
marklundin added a commit that referenced this pull request Dec 10, 2024
* Added guard around attribute assignment. Exposes attrToValue as static method

* linting fixes
marklundin added a commit that referenced this pull request Dec 11, 2024
* Added guard around attribute assignment. Exposes attrToValue as static method

* linting fixes
marklundin added a commit that referenced this pull request Feb 3, 2025
* Added guard around attribute assignment. Exposes attrToValue as static method

* linting fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants