Skip to content

fix guest button refresh timing #4873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

jonny-jeahyunchoi
Copy link
Contributor

@jonny-jeahyunchoi jonny-jeahyunchoi commented Apr 26, 2024

언제부터인가 IntroScreen오브젝트의 초기화시점이 당겨지면서 게스트진입 버튼 초기화가 CommandLIneOption 이 세팅되기전에 실행되며 정상적으로 초기화되지않는문제로 확인되었습니다.

게스트진입 버튼 초기화 시점을 CommandLineOption 이후 시점으로 변경하고 추가 로그및 중복실행방지코드를 작성하였습니다.

해당 작업과는 별개로 기존에 OnLoadCommandlineOptions이 여러번불리는경우가 있는 것으로 보이는데 정리가 한번 필요해보입니다.

@jonny-jeahyunchoi jonny-jeahyunchoi requested a review from a team as a code owner April 26, 2024 06:18
@jonny-jeahyunchoi jonny-jeahyunchoi linked an issue Apr 26, 2024 that may be closed by this pull request
@jonny-jeahyunchoi jonny-jeahyunchoi merged commit 978d026 into prepare/170.0.x Apr 26, 2024
16 checks passed
@jonny-jeahyunchoi
Copy link
Contributor Author

일단 사후리뷰로 머지진행합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeustButton 나오지않는문제
1 participant