pool_i.h: Fix to warning for signed/unsigned mismatch. #4389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauwming
approved these changes
Apr 8, 2025
nanangizz
approved these changes
Apr 9, 2025
LeonidGoltsblat
added a commit
to LeonidGoltsblat/pjproject
that referenced
this pull request
Apr 10, 2025
Create a non-expandable pool and request more memory than is left in the current block
LeonidGoltsblat
added a commit
to LeonidGoltsblat/pjproject
that referenced
this pull request
Apr 11, 2025
The bug in pjsip#4389 (when PJ_POOL_ALIGN_PTR(block->cur, alignment) > block->end) is not yet reproducible consistently on all platforms. The test is temporarily disabled.
|
@sauwming, @nanangizz, @amubiera As a result, the memory pool may now return memory that falls outside the allocated block boundaries. Does it poses a little risk to the stability of PJSIP? 😄 I tried to reproduce this situation in currently unmerged #4360, but have no stable reproducing on all platforms yet. |
|
@LeonidGoltsblat That is true. PR (#4391) created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes new warning added by #4382