[feat]: Add Auto-Accept EULA functionality to OM #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in needing an RMT Client, and dependencies, to resolve tests again. Signed-off-by: Janice Bailey <[email protected]>
…_Product" This reverts commit 44c3827.
DownloadProductToFile has client and product access so this is a natural spot for this.
We moved the logic from DownloadProductToFile to GetLatestProductFile This covers multiple commands that need this check due to EULA changes. Affects download-product, product-metadata, config-template TODO: Determine what to do about EULAs Signed-off-by: Janice Bailey <[email protected]>
Signed-off-by: Ryan Hall <[email protected]>
Signed-off-by: Janice Bailey <[email protected]>
ryanhallware
added
the
platform-automation
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
Looks good to me! Only Q: @rhall-pivotal did you test this in a local build as well against a live RMT system? |
drich10
approved these changes
Jun 11, 2024
yharish991
reviewed
Jun 12, 2024
|
Please squash WIP commits or rewrite the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.