Skip to content

Fix broken tests due to missing Logger #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

ehelms
Copy link
Contributor

@ehelms ehelms commented Feb 10, 2025

The failing tests are unrelated to #173 and appear to be caused by a change in concurrent ruby and Rails.

See https://stackoverflow.com/questions/79360526/uninitialized-constant-activesupportloggerthreadsafelevellogger-nameerror

@ehelms
Copy link
Contributor Author

ehelms commented Feb 13, 2025

@mathieujobin Can you trigger the tests?

@ehelms
Copy link
Contributor Author

ehelms commented Feb 17, 2025

@mathieujobin Thanks! Can you take a look at the tests now and I'll rebase my other PR if you merge?

Copy link
Collaborator

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's all that was needed?

Thanks so much for looking into it and putting the fix in

I am happy to know other people still rely on this gem

Add yourself to the contributor list as you rebase your other PR if you want.

Cheers

@mathieujobin mathieujobin merged commit a654f73 into pitr:master Feb 17, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants