Add previous_text context to ElevenLabsHttpTTSService #1600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
This was referenced Apr 16, 2025
filipi87
reviewed
Apr 16, 2025
Comment on lines
+12
to
+20
| - Added `previous_text` context support to ElevenLabsHttpTTSService, improving | ||
| speech consistency across sentences within an LLM response. |
There was a problem hiding this comment.
Cool, it makes a lot of sense.
filipi87
reviewed
Apr 16, 2025
Comment on lines
531
to
532
| self._cumulative_time = 0 | ||
| self._started = False | ||
| self._previous_text = "" |
There was a problem hiding this comment.
Should we create a clear or reset function to centralize where we are resetting these internal states ?
filipi87
reviewed
Apr 16, 2025
Comment on lines
539
to
540
| self._started = False | ||
| self._cumulative_time = 0 | ||
| self._previous_text = "" |
There was a problem hiding this comment.
Like we are resetting the exactly same variables here.
filipi87
reviewed
Apr 16, 2025
| # Include previous text as context if available | ||
| if self._previous_text: | ||
| payload["previous_text"] = self._previous_text | ||
| print(f"Previous text: {self._previous_text}") |
There was a problem hiding this comment.
nit: should we keep it, maybe replace by logger ?
There was a problem hiding this comment.
Yes! My mistake.
Update: Actually, I'll just remove it. This log seems unnecessary.
filipi87
approved these changes
Apr 16, 2025
markbackman
force-pushed
the
mb/11labs-http-timestamps
branch
from
3bb1ff8 to
384f809
Compare
markbackman
force-pushed
the
mb/11labs-previous-text
branch
from
4b21dab to
1e0a9d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
From 11Labs docs on previous_text:
For HTTP requests, this parameter provides continuity between HTTP responses. We're passing in previous sentences from the bot's current turn.