LLM aggregator params #1588
Merged
LLM aggregator params #1588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipi87
reviewed
Apr 16, 2025
Comment on lines
-123
to
-124
| user_kwargs: Mapping[str, Any] = {}, | ||
| assistant_kwargs: Mapping[str, Any] = {}, |
There was a problem hiding this comment.
In the changelog, we mention that these parameters are deprecated, but here we are removing them.
Is that intentional ? I think we should fix either the changelog or here.
There was a problem hiding this comment.
Ooops, they are not deprecated. They are just removed. No one has ever used those anyways.
There was a problem hiding this comment.
Changelog updated.
filipi87
reviewed
Apr 16, 2025
Comment on lines
-874
to
-875
| user_kwargs: Mapping[str, Any] = {}, | ||
| assistant_kwargs: Mapping[str, Any] = {}, |
There was a problem hiding this comment.
And in all the other LLMs actually.
aconchillo
force-pushed
the
aleix/llm-aggregator-params
branch
from
e2adc3f to
6a209c8
Compare
aconchillo
force-pushed
the
aleix/llm-aggregator-params
branch
from
6a209c8 to
f385cc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
We replace kwargs with actual classes which will make it easier to set parameters and allow users to configure the aggregators.