Skip to content

Add go-completed job to lint and test workflows #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

Warashi
Copy link
Member

@Warashi Warashi commented May 28, 2025

What this PR does:

Add job go-completed, which runs after the lint and test.

Why we need it:

To set this as required checks at branch protection rules.
We cannot set lint/test as required when merging PRs without this.

Which issue(s) this PR fixes:

Part of #5867

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.39%. Comparing base (0fcfb5e) to head (d09bbca).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5887      +/-   ##
==========================================
- Coverage   24.40%   24.39%   -0.02%     
==========================================
  Files         444      444              
  Lines       48731    48731              
==========================================
- Hits        11893    11887       -6     
- Misses      35872    35878       +6     
  Partials      966      966              
Flag Coverage Δ
. 24.39% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi Warashi marked this pull request as ready for review May 28, 2025 00:54
@Warashi Warashi requested a review from a team as a code owner May 28, 2025 00:54
@Warashi Warashi enabled auto-merge (squash) May 28, 2025 01:12
@Warashi Warashi merged commit 9c2bae7 into master May 28, 2025
41 of 42 checks passed
@Warashi Warashi deleted the ci-lint-test-completed-job branch May 28, 2025 01:52
@github-actions github-actions bot mentioned this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants