Skip to content

[SDK] Copy SDK related packages to under the pkg/plugin/sdk #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

Warashi
Copy link
Member

@Warashi Warashi commented May 26, 2025

What this PR does:

as title

Why we need it:

They are parts of the SDK, so it's clear to put them under the SDK directory.

Which issue(s) this PR fixes:

Part of #5867

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@Warashi Warashi marked this pull request as ready for review May 26, 2025 07:20
@Warashi Warashi requested a review from a team as a code owner May 26, 2025 07:20
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 60.74332% with 338 lines in your changes missing coverage. Please review.

Project coverage is 28.55%. Comparing base (a6bf12e) to head (24bbf90).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/diff/diff.go 76.99% 54 Missing and 18 partials ⚠️
pkg/plugin/sdk/logpersister/stagelogpersister.go 41.28% 62 Missing and 2 partials ⚠️
.../toolregistry/toolregistrytest/toolregistrytest.go 0.00% 51 Missing ⚠️
pkg/plugin/sdk/logpersister/persister.go 55.55% 48 Missing ⚠️
.../sdk/logpersister/logpersistertest/logpersister.go 0.00% 23 Missing ⚠️
pkg/plugin/sdk/diff/result.go 68.65% 19 Missing and 2 partials ⚠️
pkg/plugin/sdk/pipedapi/client.go 0.00% 20 Missing ⚠️
pkg/plugin/sdk/toolregistry/toolregistry.go 0.00% 15 Missing ⚠️
pkg/plugin/sdk/diff/renderer.go 90.97% 11 Missing and 2 partials ⚠️
pkg/plugin/sdk/signalhandler/handler.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5874      +/-   ##
==========================================
+ Coverage   28.05%   28.55%   +0.50%     
==========================================
  Files         510      520      +10     
  Lines       54420    55284     +864     
==========================================
+ Hits        15267    15787     +520     
- Misses      37997    38317     +320     
- Partials     1156     1180      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi Warashi enabled auto-merge (squash) May 26, 2025 07:24
@Warashi Warashi merged commit eaaec1e into master May 26, 2025
19 of 22 checks passed
@Warashi Warashi deleted the sdk-copy-subpackages branch May 26, 2025 07:26
@github-actions github-actions bot mentioned this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants