-
Notifications
You must be signed in to change notification settings - Fork 182
[K8s Plugin] Implement generateVariantWorkloadManifests #5864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K8s Plugin] Implement generateVariantWorkloadManifests #5864
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5864 +/- ##
==========================================
+ Coverage 27.97% 28.05% +0.07%
==========================================
Files 510 510
Lines 54354 54429 +75
==========================================
+ Hits 15204 15268 +64
- Misses 37996 38004 +8
- Partials 1154 1157 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'll resolve the conflicts after merging #5863 |
…-variant-workload-manifests Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
I resolved the conflicts. |
for _, tc := range testcases { | ||
t.Run(tc.name, func(t *testing.T) { | ||
manifests, err := provider.LoadManifestsFromYAMLFile(tc.manifestsFile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add t.Parallel()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, added 7991db8.
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@t-kikuc sorry, please re-review. |
* Implement generateVariantWorkloadManifests Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Add test for generateVariantWorkloadManifests Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: Arya Soni <[email protected]>
What this PR does:
as title
Why we need it:
It is to be used in the canary/baseline rollout like the following codes:
pipecd/pkg/app/piped/executor/kubernetes/canary.go
Lines 181 to 185 in e5ce1cc
pipecd/pkg/app/piped/executor/kubernetes/baseline.go
Lines 151 to 155 in e5ce1cc
Which issue(s) this PR fixes:
Part of #5764
Does this PR introduce a user-facing change?: No