[K8s Plugin] Add helper function to add variant label and annotation #5857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifests. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…nifests. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…uster plugin Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5857 +/- ##
==========================================
- Coverage 27.79% 27.77% -0.02%
==========================================
Files 510 510
Lines 54329 54316 -13
==========================================
- Hits 15101 15088 -13
Misses 38082 38082
Partials 1146 1146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
reviewed
May 21, 2025
|
|
||
| for _, tc := range testcases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| manifests, err := provider.ParseManifests(tc.inputYAML) |
There was a problem hiding this comment.
add t.Parallel()? (I'm not confident😅)
There was a problem hiding this comment.
Oops, thank you. I'll add it.
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
t-kikuc
approved these changes
May 22, 2025
aryasoni98
pushed a commit
to aryasoni98/pipecd
that referenced
this pull request
May 24, 2025
…ipe-cd#5857) * Add a function to add variant labels and annotations to the given manifests. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Use a helper function to add variant labels and annotations to all manifests. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Define and use addVariantLabelsAndAnnotations function in k8s_multicluster plugin Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Add t.Parallel() to test cases. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: Arya Soni <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
to simplify codes
Which issue(s) this PR fixes:
Part of #5764
Does this PR introduce a user-facing change?: No