Skip to content

[Plugin SDK] Change ApplicationLiveState.HealthStatus to private method #5829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025

Conversation

Warashi
Copy link
Member

@Warashi Warashi commented May 16, 2025

What this PR does:

Implement application health status calculation in the SDK.

Why we need it:

To provide consistent application health state across all plugins.

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.63%. Comparing base (2047e9a) to head (0dbaa22).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../app/pipedv1/plugin/kubernetes/livestate/plugin.go 0.00% 1 Missing ⚠️
...plugin/kubernetes_multicluster/livestate/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5829      +/-   ##
==========================================
+ Coverage   27.62%   27.63%   +0.01%     
==========================================
  Files         508      508              
  Lines       54116    54117       +1     
==========================================
+ Hits        14948    14954       +6     
+ Misses      38031    38026       -5     
  Partials     1137     1137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi Warashi marked this pull request as ready for review May 16, 2025 00:37
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@t-kikuc t-kikuc merged commit 13f1214 into master May 16, 2025
19 checks passed
@t-kikuc t-kikuc deleted the sdk-app-health-status-auto-calc branch May 16, 2025 01:08
@github-actions github-actions bot mentioned this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants