-
Notifications
You must be signed in to change notification settings - Fork 182
Add test for LoadApplication configv1 #5818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
plugins: | ||
plugin-1: | ||
plugin-2: | ||
input: | ||
version: 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is our expected application plugins config
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5818 +/- ##
==========================================
+ Coverage 27.63% 27.65% +0.01%
==========================================
Files 508 508
Lines 54116 54116
==========================================
+ Hits 14954 14964 +10
+ Misses 38025 38015 -10
Partials 1137 1137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
Signed-off-by: khanhtc1202 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What this PR does:
as title
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: