Skip to content

Unify avatar and username into single user menu button and add logout icon in header #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

kiratlog
Copy link
Contributor

@kiratlog kiratlog commented May 14, 2025

What this PR does:

Why we need it:

Which issue(s) this PR fixes:

Fixes #5794

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@khanhtc1202 khanhtc1202 changed the title Unify avatar and username into single user menu button and add logout… Unify avatar and username into single user menu button and add logout icon in header May 15, 2025
@khanhtc1202
Copy link
Member

khanhtc1202 commented May 15, 2025

@kiratlog CI has failed, please run make lint/web FIX=true on your local to fix the web lint error.

@t-kikuc
Copy link
Member

t-kikuc commented May 15, 2025

@hongky-1994
Please review this after fixing lint 🙏

Signed-off-by: Kirat <[email protected]>
@kiratlog
Copy link
Contributor Author

Fixed the lints.
Thanks

Copy link
Contributor

@hongky-1994 hongky-1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully I clicked my name too.
image

@t-kikuc t-kikuc merged commit 5e7afe1 into pipe-cd:master May 16, 2025
16 checks passed
@t-kikuc t-kikuc added this to v0.52.0 May 23, 2025
@t-kikuc t-kikuc moved this to Done in v0.52.0 May 23, 2025
@github-actions github-actions bot mentioned this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Better way to show how to logout on PipeCD control plane
4 participants