Add implementation of OCI push and pull with authentication #5805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CI package Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5805 +/- ##
==========================================
+ Coverage 27.23% 27.28% +0.04%
==========================================
Files 508 508
Lines 53886 53922 +36
==========================================
+ Hits 14677 14713 +36
Misses 38093 38093
Partials 1116 1116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
commented
May 8, 2025
Comment on lines
-43
to
+46
| r, ref, err := parseOCIURL(sourceURL) | ||
| repo, ref, err := parseOCIURL(sourceURL) |
There was a problem hiding this comment.
This change is to make consistency with push.go
t-kikuc
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
We want to support push/pull plugins to/from OCI Registry with authentication.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No