-
Notifications
You must be signed in to change notification settings - Fork 183
[K8s Plugin] Enhance Manifest struct with deep copy functionality and conversion methods #5803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ethods Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…er plugin. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
ConvertToStructuredObject changed the behavior around secret data. Now it decodes the base64 encoded data into the provided object. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5803 +/- ##
==========================================
+ Coverage 27.14% 27.24% +0.10%
==========================================
Files 508 508
Lines 53803 53823 +20
==========================================
+ Hits 14603 14665 +62
+ Misses 38084 38036 -48
- Partials 1116 1122 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
expected: "74bd68bm66", | ||
expected: "2k5dh9h9h9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConvertToStructuredObject changed the behavior around secret data.
Now, it decodes the base64 encoded data into the provided object.
This behavior change makes the calculated hash to be another one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ask] Just for clarify, does it affect the hash annotation for each secret when migrating to piped1? If so, we should remember it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the config-hash annotation in the workload will change when migrating to pipedv1. This annotation ensures that the workloads are rolled out when the ConfigMap and/or Secret are changed. The hash calculation will change, but the functionality will not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I got it.
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this PR does:
runtime.DefaultUnstructuredConverter.FromUnstructured
.Why we need it:
Which issue(s) this PR fixes:
Part of #5764
Does this PR introduce a user-facing change?: