Add a blog: What Happens before Deployment #5788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5788 +/- ##
========================================
Coverage 27.17% 27.18%
========================================
Files 507 507
Lines 53423 53533 +110
========================================
+ Hits 14520 14553 +33
- Misses 37796 37866 +70
- Partials 1107 1114 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khanhtc1202
reviewed
Apr 28, 2025
| 2. Determine stages | ||
|
|
||
| The planner instance runs as a goroutine in a 1:1 relationship with Deployment, allowing multiple deployments to be processed concurrently. | ||
| Also, control is implemented to prevent multiple deployments from running simultaneously for the same application. |
There was a problem hiding this comment.
Suggested change
| Also, control is implemented to prevent multiple deployments from running simultaneously for the same application. | |
| Also, piped is implemented to prevent multiple deployments from running simultaneously for the same application. |
nits
There was a problem hiding this comment.
Thank you!
I fixed it : 99b1071
khanhtc1202
reviewed
Apr 28, 2025
Signed-off-by: t-kikuc <[email protected]>
Warashi
reviewed
Apr 30, 2025
| Deployment is triggered when an application meets all four of the following conditions: | ||
|
|
||
| 1. "Automatic deployment on drift detection" is enabled | ||
| - Set the `trigger.onOutOfSync.disabled` item to `true` (**default is `false`**) |
There was a problem hiding this comment.
The default is true and set false to enable this option.
Suggested change
| - Set the `trigger.onOutOfSync.disabled` item to `true` (**default is `false`**) | |
| - Set the `trigger.onOutOfSync.disabled` item to `false` (**default is `true`**) |
There was a problem hiding this comment.
Thank you, I fixed it: 91d3f79.
I confused the double negative of disabled 😅
This trigger is disabled by default,
There was a problem hiding this comment.
@khanhtc1202 Sorry, please re-approve 🙏
Signed-off-by: t-kikuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
translated from my Japanese article: https://zenn.dev/cadp/articles/pipecd-before-deployment
Why we need it:
It helps to understand the core mechanism for PipeCD users and contributors.
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: