-
Notifications
You must be signed in to change notification settings - Fork 183
Add support for OCI registry to push/pull plugins #5779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5779 +/- ##
==========================================
- Coverage 27.17% 27.17% -0.01%
==========================================
Files 507 509 +2
Lines 53423 53521 +98
==========================================
+ Hits 14520 14546 +26
- Misses 37796 37867 +71
- Partials 1107 1108 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try
What this PR does:
pipectl plugin push
command to push plugin binary to OCI Registryoci
as an allowed scheme to download a pluginWe can use the
pipectl plugin push
as the command belowAnd we can pull the plugins from OCI Registry with the config below.
Before trying the config above, we have to patch the below lines to include the option
oci.WithInsecure()
because the local registry hosts the HTTP protocol, not the HTTPS protocol.pipecd/pkg/lifecycle/binary.go
Lines 152 to 159 in 9cc2355
Why we need it:
We want to support OCI Registry in hosting a piped plugin.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No