Skip to content

Fix to set head commit hash on pipedv1 LivestateReporter #5773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Apr 23, 2025

What this PR does:

as title

Why we need it:

I want to clarify the commit hash to track which commit is used.
Always used HEAD as the current revision in the current implementation.
PipeCD

Which issue(s) this PR fixes:

Part of #5363

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@ffjlabo ffjlabo changed the title Fix to set head commit hash on pipedv1 LivestateRporter Fix to set head commit hash on pipedv1 LivestateReporter Apr 24, 2025
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement

@ffjlabo ffjlabo enabled auto-merge (squash) April 24, 2025 03:57
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Signed-off-by: Yoshiki Fujikane <[email protected]>
@ffjlabo ffjlabo force-pushed the clarify-head-commit-hash branch from 266f7a1 to 8f23e81 Compare April 25, 2025 00:53
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.17%. Comparing base (acf9ba5) to head (8f23e81).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/livestatereporter/livestatereporter.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5773   +/-   ##
=======================================
  Coverage   27.17%   27.17%           
=======================================
  Files         507      507           
  Lines       53418    53423    +5     
=======================================
+ Hits        14515    14520    +5     
  Misses      37796    37796           
  Partials     1107     1107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ffjlabo ffjlabo merged commit 9cc2355 into master Apr 25, 2025
19 checks passed
@ffjlabo ffjlabo deleted the clarify-head-commit-hash branch April 25, 2025 00:57
@github-actions github-actions bot mentioned this pull request May 15, 2025
@github-actions github-actions bot mentioned this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants