Skip to content

add: temporary volume option #5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

na-ga
Copy link
Contributor

@na-ga na-ga commented Apr 2, 2025

What this PR does:

Added option to use PVC as temporary volume

Why we need it:

I need a workaround for a disk full problem caused by a temporary file generated by piped

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change: Nil
  • Is this breaking change: Nil
  • How to migrate (if breaking change):

@na-ga na-ga force-pushed the add-temporary-volume-option branch from 3bc3fb8 to bd40839 Compare April 2, 2025 09:00
Signed-off-by: na-ga <[email protected]>
@na-ga na-ga marked this pull request as ready for review April 2, 2025 10:42
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
I test it on the kind cluster and checked the PVC are attached to the piped pod.

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@Warashi Warashi merged commit 20eb018 into pipe-cd:master Apr 2, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Apr 3, 2025
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
* add: temporary volume option

Signed-off-by: na-ga <[email protected]>

* remove: post start

Signed-off-by: na-ga <[email protected]>

* add: storage class name

Signed-off-by: na-ga <[email protected]>

---------

Signed-off-by: na-ga <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
* add: temporary volume option

Signed-off-by: na-ga <[email protected]>

* remove: post start

Signed-off-by: na-ga <[email protected]>

* add: storage class name

Signed-off-by: na-ga <[email protected]>

---------

Signed-off-by: na-ga <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
ffjlabo pushed a commit that referenced this pull request Apr 3, 2025
* add: temporary volume option

Signed-off-by: na-ga <[email protected]>

* remove: post start

Signed-off-by: na-ga <[email protected]>

* add: storage class name

Signed-off-by: na-ga <[email protected]>

---------

Signed-off-by: na-ga <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo added a commit that referenced this pull request Apr 3, 2025
* add: temporary volume option (#5716)

* add: temporary volume option

Signed-off-by: na-ga <[email protected]>

* remove: post start

Signed-off-by: na-ga <[email protected]>

* add: storage class name

Signed-off-by: na-ga <[email protected]>

---------

Signed-off-by: na-ga <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

* Fix rolling back deployments are ignored on piped restarted event (#5717)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

* Release v0.51.1 (#5718)

Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>

---------

Signed-off-by: na-ga <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Co-authored-by: Na-ga <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: Yoshiki Fujikane <[email protected]>
@github-actions github-actions bot mentioned this pull request May 15, 2025
@github-actions github-actions bot mentioned this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants