-
Notifications
You must be signed in to change notification settings - Fork 182
add: temporary volume option #5716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: na-ga <[email protected]>
3bc3fb8
to
bd40839
Compare
Signed-off-by: na-ga <[email protected]>
Signed-off-by: na-ga <[email protected]>
ffjlabo
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
I test it on the kind cluster and checked the PVC are attached to the piped pod.
Warashi
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM.
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
* add: temporary volume option Signed-off-by: na-ga <[email protected]> * remove: post start Signed-off-by: na-ga <[email protected]> * add: storage class name Signed-off-by: na-ga <[email protected]> --------- Signed-off-by: na-ga <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
* add: temporary volume option Signed-off-by: na-ga <[email protected]> * remove: post start Signed-off-by: na-ga <[email protected]> * add: storage class name Signed-off-by: na-ga <[email protected]> --------- Signed-off-by: na-ga <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
ffjlabo
pushed a commit
that referenced
this pull request
Apr 3, 2025
* add: temporary volume option Signed-off-by: na-ga <[email protected]> * remove: post start Signed-off-by: na-ga <[email protected]> * add: storage class name Signed-off-by: na-ga <[email protected]> --------- Signed-off-by: na-ga <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
added a commit
that referenced
this pull request
Apr 3, 2025
* add: temporary volume option (#5716) * add: temporary volume option Signed-off-by: na-ga <[email protected]> * remove: post start Signed-off-by: na-ga <[email protected]> * add: storage class name Signed-off-by: na-ga <[email protected]> --------- Signed-off-by: na-ga <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix rolling back deployments are ignored on piped restarted event (#5717) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> * Release v0.51.1 (#5718) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> --------- Signed-off-by: na-ga <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Co-authored-by: Na-ga <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Added option to use PVC as temporary volume
Why we need it:
I need a workaround for a disk full problem caused by a temporary file generated by piped
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: