Skip to content

Add placeholders for k8s deployment stages #5690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

Warashi
Copy link
Member

@Warashi Warashi commented Mar 25, 2025

What this PR does:

This PR adds placeholder implementations for the Kubernetes deployment plugin.

Why we need it:

I want to clarify where to implement stages.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 25.75%. Comparing base (5079ca7) to head (83ce771).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/kubernetes/deployment/plugin.go 0.00% 24 Missing ⚠️
...p/pipedv1/plugin/kubernetes/deployment/baseline.go 0.00% 6 Missing ⚠️
...app/pipedv1/plugin/kubernetes/deployment/canary.go 0.00% 6 Missing ⚠️
...pp/pipedv1/plugin/kubernetes/deployment/primary.go 0.00% 3 Missing ⚠️
...pp/pipedv1/plugin/kubernetes/deployment/traffic.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5690      +/-   ##
==========================================
- Coverage   25.76%   25.75%   -0.01%     
==========================================
  Files         476      480       +4     
  Lines       50976    51018      +42     
==========================================
+ Hits        13135    13141       +6     
- Misses      36843    36879      +36     
  Partials      998      998              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi Warashi marked this pull request as ready for review March 25, 2025 01:30
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that made sense

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 4876900 into master Mar 25, 2025
16 of 18 checks passed
@Warashi Warashi deleted the k8s-plugin-deploy-placeholders branch March 25, 2025 01:50
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants