Skip to content

Enhance GetLivestateRequest with additional application details #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

Warashi
Copy link
Member

@Warashi Warashi commented Mar 17, 2025

What this PR does:

Updated the GetLivestateRequest to include PipedId, ApplicationName, and DeployTargets for improved context in the livestate reporting process.

Why we need it:

We need these to implement livestate/driftdetection feature

Which issue(s) this PR fixes:

Follows #5668
Part of #4980 #5363

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Updated the GetLivestateRequest to include PipedId, ApplicationName, and DeployTargets for improved context in the livestate reporting process.

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.58%. Comparing base (5ce218d) to head (43c0cbe).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5669   +/-   ##
=======================================
  Coverage   25.57%   25.58%           
=======================================
  Files         478      478           
  Lines       51240    51243    +3     
=======================================
+ Hits        13105    13108    +3     
  Misses      37130    37130           
  Partials     1005     1005           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Warashi Warashi marked this pull request as ready for review March 17, 2025 02:22
@Warashi Warashi enabled auto-merge (squash) March 17, 2025 02:25
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 55d27d1 into master Mar 17, 2025
18 checks passed
@Warashi Warashi deleted the livestate-more-info-pipedv1 branch March 17, 2025 02:52
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants