Skip to content

Set limit for gh pr list to 100 to avoid cherrypick limit #5666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Mar 14, 2025

What this PR does:

Why we need it:

The default value for the gh pr list command is 30, which is too small in case of 3-week cycle for a patch release now. We set it to 100 to avoid the error cherry-pick failed to apply.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) March 14, 2025 08:04
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khanhtc1202 khanhtc1202 merged commit 1286089 into master Mar 14, 2025
16 checks passed
@khanhtc1202 khanhtc1202 deleted the update-cherry-pick-wf branch March 14, 2025 08:08
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.57%. Comparing base (4a97422) to head (52e53da).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5666   +/-   ##
=======================================
  Coverage   25.57%   25.57%           
=======================================
  Files         478      478           
  Lines       51240    51240           
=======================================
  Hits        13105    13105           
  Misses      37130    37130           
  Partials     1005     1005           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants