Skip to content

Update golangci lint #5658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Update golangci lint #5658

merged 2 commits into from
Mar 13, 2025

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Mar 13, 2025

What this PR does:

Update golangci-lint version to v1.64.7.

docker image: https://hub.docker.com/layers/golangci/golangci-lint/v1.64.7/images/sha256-f05d6b48c3a9158485842c2e003c92936cdb6e58939d9bb64cdd3ce4ebb02e57

Why we need it:

I encountered the error related to the go version when executing make lint/go.

% make lint/go                                                                                          (git)-[master]
docker run --rm -e GOCACHE=/repo/.cache/go-build -e GOLANGCI_LINT_CACHE=/repo/.cache/golangci-lint -v XX/oss/pipe-cd/pipecd:/repo -w /repo -it golangci/golangci-lint@sha256:4e53bfe25ef2f1e14a95da42d694211080f40d118730541ce1513a83cf7587ec  golangci-lint run -v
INFO golangci-lint has version 1.62.2 built with go1.23.3 from 89476e7a on 2024-11-25T14:16:01Z
INFO [config_reader] Config search paths: [./ /repo / /root]
INFO [config_reader] Used config file .golangci.yml
Error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.1)
Failed executing command with error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.1)
make: *** [lint/go] Error 3
% go version                                                                                            (git)-[master]
go version go1.24.1 darwin/arm64

It seems that we can use it on go version 1.24 since v1.64

since v1.64 golangci-lint supports go1.24 if compiled with go1.24
golangci/golangci-lint#5225

Which issue(s) this PR fixes:

Part of #5640

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

ffjlabo added 2 commits March 13, 2025 11:11
Signed-off-by: Yoshiki Fujikane <[email protected]>
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.55%. Comparing base (d50a676) to head (92c6765).
Report is 190 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5658      +/-   ##
==========================================
+ Coverage   25.54%   25.55%   +0.01%     
==========================================
  Files         477      477              
  Lines       51101    51101              
==========================================
+ Hits        13054    13060       +6     
+ Misses      37042    37036       -6     
  Partials     1005     1005              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ffjlabo ffjlabo marked this pull request as ready for review March 13, 2025 02:28
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ffjlabo ffjlabo enabled auto-merge (squash) March 13, 2025 02:34
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ffjlabo ffjlabo merged commit 883243c into master Mar 13, 2025
18 checks passed
@ffjlabo ffjlabo deleted the update-golangci-lint branch March 13, 2025 02:39
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants