Skip to content

Fix index ensurer error on alter table command run #5644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

khanhtc1202
Copy link
Member

What this PR does:

This change fixes the error on running the alter table query.

"failed to create required indexes on sql database: Error 1048: Column 'DeploymentTraceCommitHash' cannot be null"

Why we need it:

Since the previous data on Deployment model didn't have DeploymentTraceCommitHash value, the first Alter Table statement will be failed

Which issue(s) this PR fixes:

Follow PR #5631

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) March 10, 2025 10:33
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.56%. Comparing base (6cfeb58) to head (96178bb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5644   +/-   ##
=======================================
  Coverage   25.56%   25.56%           
=======================================
  Files         477      477           
  Lines       50945    50945           
=======================================
  Hits        13022    13022           
  Misses      36918    36918           
  Partials     1005     1005           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khanhtc1202 khanhtc1202 merged commit bc1a61b into master Mar 10, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the fix-index-ensurer branch March 10, 2025 10:43
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants