Skip to content

Feat/insight UI update #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2025
Merged

Feat/insight UI update #5633

merged 4 commits into from
Mar 7, 2025

Conversation

hongky-1994
Copy link
Contributor

@hongky-1994 hongky-1994 commented Mar 6, 2025

What this PR does:
CleanShot 2025-03-07 at 02 21 07

Update insight page ui

  • Add application-count chart: Show total applications
  • Add application-by-piped chart: Show top 3 piped which have the most apps
  • Add piped-count chart: Show total piped, enabled piped, online piped
  • Add deployment-24h: show number of deployments trigger today, + percent of failed deployments

Why we need it:

  • Current pipedv1 doesn't havekind and platformProvider. Therefore in Insight screen, Block Kubernetes; Terraform; Lambda; Cloudrun; Ecs are not suitable.

Which issue(s) this PR fixes:

Fixes #5607

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

- Add application-count chart
- Add application-by-piped chart
- Add piped-count chart
- Add deployment-24h

Signed-off-by: kypham <[email protected]>
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.64%. Comparing base (992f17d) to head (847b163).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5633   +/-   ##
=======================================
  Coverage   26.63%   26.64%           
=======================================
  Files         478      478           
  Lines       50780    50780           
=======================================
+ Hits        13526    13530    +4     
+ Misses      36187    36184    -3     
+ Partials     1067     1066    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@t-kikuc
Copy link
Member

t-kikuc commented Mar 7, 2025

@khanhtc1202 @hongky-1994
LGTM but when to release this feature?
Although the current graphs of K8s, ECS, ... are not suitable for pipedv1, v0 pipeds will exist even after pipedv1 release.

@khanhtc1202
Copy link
Member

@t-kikuc keeping the counter graph just for pipedv0 makes the frontend logic for this page more complicated than it should be, so me and @hongky-1994 thought that we should reimplement the page such that both pipedv0 and v1 work. So as soon as it's ready, I want to release it.
The new implementation uses the same API as the previous one, just not using kind/platform data. Lemme know your thought 👀

@t-kikuc
Copy link
Member

t-kikuc commented Mar 7, 2025

@khanhtc1202
Thank you. I don't think removing the current graphs is a problem!
I just wanted to confirm.

t-kikuc
t-kikuc previously approved these changes Mar 7, 2025
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202
Copy link
Member

@hongky-1994 please sign-off the commit 👀

@hongky-1994
Copy link
Contributor Author

@t-kikuc @khanhtc1202 Thank for reviewing my code, I have update sign-off commit.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great 🔥

@khanhtc1202 khanhtc1202 merged commit 0a5f895 into master Mar 7, 2025
16 checks passed
@khanhtc1202 khanhtc1202 deleted the feat/insight-ui-update branch March 7, 2025 06:31
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI for Insight page to show
3 participants