-
Notifications
You must be signed in to change notification settings - Fork 182
Feat/insight UI update #5633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/insight UI update #5633
Conversation
- Add application-count chart - Add application-by-piped chart - Add piped-count chart - Add deployment-24h Signed-off-by: kypham <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5633 +/- ##
=======================================
Coverage 26.63% 26.64%
=======================================
Files 478 478
Lines 50780 50780
=======================================
+ Hits 13526 13530 +4
+ Misses 36187 36184 -3
+ Partials 1067 1066 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@khanhtc1202 @hongky-1994 |
@t-kikuc keeping the counter graph just for pipedv0 makes the frontend logic for this page more complicated than it should be, so me and @hongky-1994 thought that we should reimplement the page such that both pipedv0 and v1 work. So as soon as it's ready, I want to release it. |
@khanhtc1202 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hongky-1994 please sign-off the commit 👀 |
Signed-off-by: kypham <[email protected]>
847b163
to
bfc5ec0
Compare
@t-kikuc @khanhtc1202 Thank for reviewing my code, I have update sign-off commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look great 🔥
What this PR does:

Update insight page ui
Why we need it:
Which issue(s) this PR fixes:
Fixes #5607
Does this PR introduce a user-facing change?: