Skip to content

Remove deprecated ReportEventHandled rpc from piped API #5620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

khanhtc1202
Copy link
Member

What this PR does:

as title

Why we need it:

This RPC is no more used by piped(s) from 3 years ago 👴

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) March 4, 2025 06:34
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.57%. Comparing base (874278e) to head (2df728b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5620      +/-   ##
==========================================
+ Coverage   26.56%   26.57%   +0.01%     
==========================================
  Files         475      475              
  Lines       50592    50582      -10     
==========================================
+ Hits        13438    13444       +6     
+ Misses      36091    36075      -16     
  Partials     1063     1063              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the definitions of request/response messages remain.
Please remove them.

message ReportEventsHandledRequest {
repeated string event_ids = 1 [(validate.rules).repeated.min_items = 1];
}
message ReportEventsHandledResponse {
}

@khanhtc1202
Copy link
Member Author

@Warashi Thanks, removed by 2df728b

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that ReportEventsHandled() is not called anywhere.

What "old Piped" means is unclear 😓

@khanhtc1202 khanhtc1202 merged commit 6cf5097 into master Mar 4, 2025
16 checks passed
@khanhtc1202 khanhtc1202 deleted the remove-event-handled-rpc branch March 4, 2025 06:50
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants