Update application-detail-page, deployment-detail-page with deployment target info row #5562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t target info row Signed-off-by: kypham <[email protected]>
Signed-off-by: kypham <[email protected]>
hongky-1994
requested review from
khanhtc1202,
ffjlabo,
t-kikuc and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5562 +/- ##
=======================================
Coverage 26.38% 26.39%
=======================================
Files 465 465
Lines 49940 49940
=======================================
+ Hits 13179 13183 +4
+ Misses 35705 35702 -3
+ Partials 1056 1055 -1 ☔ View full report in Codecov by Sentry. |
t-kikuc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
As titile
Why we need it:
For pages application-detail and deployment-target that using piped v1,
Which issue(s) this PR fixes:
Fixes #5561
Does this PR introduce a user-facing change?: