Skip to content

Ensure ApplicationKind only accept enum defined value #5532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

khanhtc1202
Copy link
Member

What this PR does:

as title

Why we need it:

Instead of not validating the ApplicationKind, which web form submitted to the API as preparation for pipedv1 managing application, we should mark this as accepting only defined enum value. With application managing by pipedv1, this field is not required, but the web form will send value 0 (kind: Kubernetes) as default; this field would not be used in any logic on the server side of piped side in case of v1 piped.

Which issue(s) this PR fixes:

Fllow #5517

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) February 3, 2025 07:41
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.43%. Comparing base (bdcc7a2) to head (891e02e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5532      +/-   ##
==========================================
- Coverage   26.44%   26.43%   -0.01%     
==========================================
  Files         465      465              
  Lines       49858    49858              
==========================================
- Hits        13186    13182       -4     
- Misses      35618    35621       +3     
- Partials     1054     1055       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202 khanhtc1202 merged commit 2e3d913 into master Feb 3, 2025
17 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the update-webservice branch February 3, 2025 08:08
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants