Skip to content

fix: remove error disableBackdropClick is deprecated #5503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

hongky-1994
Copy link
Contributor

What this PR does:

  • remove error disableBackdropClick is deprecated
    CleanShot 2025-01-21 at 16 44 07

Why we need it:

  • Resolve error warning in web console and prevent unwanted behavior

Which issue(s) this PR fixes:

  • none

Does this PR introduce a user-facing change?:

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): none

@khanhtc1202
Copy link
Member

khanhtc1202 commented Jan 21, 2025

@hongky-1994 Thanks for the contribute 🎉 Please sign off the commit follow the github actions's log https://github.com/pipe-cd/pipecd/pull/5503/checks?check_run_id=35924678119

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.29%. Comparing base (e0dfc18) to head (96dcca5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5503   +/-   ##
=======================================
  Coverage   26.28%   26.29%           
=======================================
  Files         464      464           
  Lines       49624    49624           
=======================================
+ Hits        13043    13047    +4     
+ Misses      35547    35544    -3     
+ Partials     1034     1033    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hongky-1994 hongky-1994 force-pushed the fix/depreated-disableBackdropClick-error branch from 1d2d909 to 96dcca5 Compare January 21, 2025 12:40
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and welcome 👍

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THank you!

@t-kikuc t-kikuc merged commit eac110a into master Jan 22, 2025
18 checks passed
@t-kikuc t-kikuc deleted the fix/depreated-disableBackdropClick-error branch January 22, 2025 02:44
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants