Skip to content

Add context to RunBinary interface #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add context to RunBinary interface #5384

merged 1 commit into from
Dec 3, 2024

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Dec 3, 2024

What this PR does:

Add context to the RunBinary interface to have more control.
Also, add test for the DownloadBinary function.

Why we need it:

Instead of context.Background, use context passed by the run binary caller side would gain the caller more control on the binary lifecycle.

Which issue(s) this PR fixes:

Part of #4980
Follows #5361

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 25.72%. Comparing base (b2b9148) to head (a6fbcd4).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/launcher/cmd/launcher/launcher.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5384      +/-   ##
==========================================
- Coverage   25.82%   25.72%   -0.11%     
==========================================
  Files         445      446       +1     
  Lines       47859    48141     +282     
==========================================
+ Hits        12361    12382      +21     
- Misses      34536    34787     +251     
- Partials      962      972      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@t-kikuc t-kikuc merged commit 29c436f into master Dec 3, 2024
17 of 18 checks passed
@t-kikuc t-kikuc deleted the context-lifecycle branch December 3, 2024 05:47
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants